-
Notifications
You must be signed in to change notification settings - Fork 112
Add link checker for doc build and test #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 14 commits into
NVIDIA:branch-25.08
from
rgsl888prabhu:add_link_checker
Jul 28, 2025
Merged
Add link checker for doc build and test #229
rapids-bot
merged 14 commits into
NVIDIA:branch-25.08
from
rgsl888prabhu:add_link_checker
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…lic into add_link_checker
tmckayus
approved these changes
Jul 28, 2025
jameslamb
approved these changes
Jul 28, 2025
Member
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
In a follow-up PR, you should fix anything that's redirecting permanently, like these:
( faq: line 10) redirect https://hub.docker.com/r/nvidia/ - permanently to https://hub.docker.com/u/nvidia
( introduction: line 122) redirect https://www.ampl.com/ - permanently to https://ampl.com/
Benefits of that:
- faster page loads for docs
- protection against those redirects turning into broken links in the future if the redirection is ever removed
Collaborator
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The link checker will go through all the links and flag any broken links in the doc
Checklist